From de095e74aecbed764896377faa3db71298a0a4ce Mon Sep 17 00:00:00 2001 From: Joscha Date: Sun, 7 Aug 2022 00:28:22 +0200 Subject: [PATCH] Change binding for external editor In order to avoid collisions with ctrl+e, we need a new binding. In bash/readline, ctrl+x is used as a sort of leader key to initiate multi-key bindings. I don't think I'll implement multi-key combinations any time soon, so now ctrl+x stands for 'edit in eXternal editor'. --- src/ui/util.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ui/util.rs b/src/ui/util.rs index 402372f..1cab38c 100644 --- a/src/ui/util.rs +++ b/src/ui/util.rs @@ -46,7 +46,7 @@ pub fn list_editor_key_bindings( bindings.binding("ctrl+d, delete", "delete after cursor"); bindings.binding("ctrl+l", "clear editor contents"); if can_edit_externally { - bindings.binding("ctrl+e", "edit in $EDITOR"); + bindings.binding("ctrl+x", "edit in external editor"); } bindings.empty(); @@ -83,7 +83,7 @@ pub fn handle_editor_key_event( key!(Ctrl + 'h') | key!(Backspace) => editor.backspace(terminal.frame()), key!(Ctrl + 'd') | key!(Delete) => editor.delete(), key!(Ctrl + 'l') => editor.clear(), - key!(Ctrl + 'e') if can_edit_externally => editor.edit_externally(terminal, crossterm_lock), // TODO Change to some other binding + key!(Ctrl + 'x') if can_edit_externally => editor.edit_externally(terminal, crossterm_lock), // Cursor movement key!(Ctrl + 'b') | key!(Left) => editor.move_cursor_left(terminal.frame()),