From 7b10670a8832bf2969e530fddcd4241c7bca39c8 Mon Sep 17 00:00:00 2001
From: Joscha <joscha@plugh.de>
Date: Mon, 10 Feb 2025 15:42:21 +0100
Subject: [PATCH] Fix eslint warnings

---
 gdn-app/src/components/CNavbar.vue         |  4 +++-
 gdn-app/src/components/CNavbarDropdown.vue |  2 +-
 gdn-app/src/components/CNote.vue           |  2 +-
 gdn-app/src/components/CNoteEditor.vue     |  4 ++--
 gdn-app/src/lib/path.ts                    | 12 +++++++++---
 gdn-app/src/stores/notes.ts                |  5 +++--
 6 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/gdn-app/src/components/CNavbar.vue b/gdn-app/src/components/CNavbar.vue
index 0bb8cbc..8d64965 100644
--- a/gdn-app/src/components/CNavbar.vue
+++ b/gdn-app/src/components/CNavbar.vue
@@ -41,7 +41,9 @@ function createSomeNotes() {
     .map(({ it }) => it);
 }
 
-onMounted(() => createSomeNotes());
+onMounted(() => {
+  createSomeNotes();
+});
 </script>
 
 <template>
diff --git a/gdn-app/src/components/CNavbarDropdown.vue b/gdn-app/src/components/CNavbarDropdown.vue
index e3fd28c..e3eb6fe 100644
--- a/gdn-app/src/components/CNavbarDropdown.vue
+++ b/gdn-app/src/components/CNavbarDropdown.vue
@@ -19,7 +19,7 @@ const { floatingStyles } = useFloating(reference, floating, {
     offset(4),
     size({
       apply({ availableHeight, elements }) {
-        elements.floating.style.maxHeight = `${Math.max(100, availableHeight)}px`;
+        elements.floating.style.maxHeight = `${Math.max(100, availableHeight).toFixed()}px`;
       },
     }),
   ],
diff --git a/gdn-app/src/components/CNote.vue b/gdn-app/src/components/CNote.vue
index b85cf8b..f561d67 100644
--- a/gdn-app/src/components/CNote.vue
+++ b/gdn-app/src/components/CNote.vue
@@ -41,7 +41,7 @@ const children = computed(() => {
   const seen = new Map<string, number>();
   const children = [];
   for (const id of note.value.children) {
-    const iteration = seen.get(id) || 0;
+    const iteration = seen.get(id) ?? 0;
     seen.set(id, iteration + 1);
     children.push(new Segment(id, iteration));
   }
diff --git a/gdn-app/src/components/CNoteEditor.vue b/gdn-app/src/components/CNoteEditor.vue
index d9cb76c..80a8d8c 100644
--- a/gdn-app/src/components/CNoteEditor.vue
+++ b/gdn-app/src/components/CNoteEditor.vue
@@ -13,7 +13,7 @@ const emit = defineEmits<{
 }>();
 
 const textarea = useTemplateRef<HTMLTextAreaElement>("textarea");
-const text = ref(props.initialText || "");
+const text = ref(props.initialText ?? "");
 
 onMounted(() => {
   textarea.value?.focus();
@@ -23,7 +23,7 @@ onMounted(() => {
 function updateTextareaHeight() {
   if (!textarea.value) return;
   textarea.value.style.height = "0px";
-  textarea.value.style.height = `${textarea.value.scrollHeight}px`;
+  textarea.value.style.height = `${textarea.value.scrollHeight.toFixed()}px`;
 }
 
 function onInput() {
diff --git a/gdn-app/src/lib/path.ts b/gdn-app/src/lib/path.ts
index 5033695..7860bf2 100644
--- a/gdn-app/src/lib/path.ts
+++ b/gdn-app/src/lib/path.ts
@@ -10,13 +10,19 @@ export class Segment {
   }
 
   static parse(text: string): Segment {
-    const match = text.match(/^([^/]+):([0-9]{1,10})$/);
+    const match = /^([^/]+):([0-9]{1,10})$/.exec(text);
     assert(match !== null, "invalid segment string");
-    return new Segment(match[1]!, Number.parseInt(match[2]!));
+
+    const id = match[1];
+    const iteration = match[2];
+    assert(id !== undefined, "invalid regex");
+    assert(iteration !== undefined, "invalid regex");
+
+    return new Segment(id, Number.parseInt(iteration));
   }
 
   fmt(): string {
-    return `${this.id}:${this.iteration}`;
+    return `${this.id}:${this.iteration.toFixed()}`;
   }
 
   eq(other: Segment): boolean {
diff --git a/gdn-app/src/stores/notes.ts b/gdn-app/src/stores/notes.ts
index 7a9fc69..aee1c78 100644
--- a/gdn-app/src/stores/notes.ts
+++ b/gdn-app/src/stores/notes.ts
@@ -14,7 +14,7 @@ export const useNotesStore = defineStore("notes", () => {
     const result = new Map<string, Set<string>>();
     for (const note of notes.value.values()) {
       for (const childId of note.children) {
-        const parents = result.get(childId) || new Set();
+        const parents = result.get(childId) ?? new Set();
         result.set(childId, parents);
         parents.add(note.id);
       }
@@ -27,12 +27,13 @@ export const useNotesStore = defineStore("notes", () => {
   }
 
   function getParents(id: string): ReadonlySet<string> {
-    return parents.value.get(id) || new Set();
+    return parents.value.get(id) ?? new Set();
   }
 
   function createNote(text: string): Note {
     const id = crypto.randomUUID();
     notes.value.set(id, { id, text, children: [] });
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     return notes.value.get(id)!; // Re-getting so returned Note is reactive
   }