Garmelon/geneross
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix off-by-one error in Chromosome

Browse source
This commit is contained in:
Joscha 2017-04-27 20:55:58 +00:00
parent 15640c9656
commit 0d686b2008
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Chromosome.cpp
View file

@ -193,7 +193,7 @@ void Chromosome::mutateGene(Gene& gene)
std::pair<std::vector<Chromosome::Gene>::iterator, std::vector<Chromosome::Gene>::iterator> std::pair<std::vector<Chromosome::Gene>::iterator, std::vector<Chromosome::Gene>::iterator>
Chromosome::selectSegment(std::vector<Chromosome::Gene>& genes) Chromosome::selectSegment(std::vector<Chromosome::Gene>& genes)
{ {
std::uniform_int_distribution<> randdist(0, genes.size()); std::uniform_int_distribution<> randdist(0, genes.size()-1);
auto first = genes.begin() + randdist(*Chromosome::re); auto first = genes.begin() + randdist(*Chromosome::re);
auto second = genes.begin() + randdist(*Chromosome::re); auto second = genes.begin() + randdist(*Chromosome::re);
@ -212,7 +212,7 @@ Chromosome::selectGene(std::vector<Chromosome::Gene>& genes)
if (genes.empty()) { if (genes.empty()) {
return genes.end(); return genes.end();
} else { } else {
std::uniform_int_distribution<> posdist(0, genes.size()); std::uniform_int_distribution<> posdist(0, genes.size()-1);
return genes.begin() + posdist(*Chromosome::re); return genes.begin() + posdist(*Chromosome::re);
} }
} }