Enable some warnings

src/euph/api/types.rs

@@ -304,10 +304,10 @@ impl Serialize for Snowflake {
 
 struct SnowflakeVisitor;
 
-impl<'de> de::Visitor<'de> for SnowflakeVisitor {
+impl de::Visitor<'_> for SnowflakeVisitor {
     type Value = Snowflake;
 
-    fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
+    fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(formatter, "a base36 string of length 13")
     }
 

src/logger.rs

@@ -105,11 +105,11 @@ impl MsgStore<LogMsg> for Logger {
 }
 
 impl Log for Logger {
-    fn enabled(&self, _metadata: &log::Metadata) -> bool {
+    fn enabled(&self, _metadata: &log::Metadata<'_>) -> bool {
         true
     }
 
-    fn log(&self, record: &log::Record) {
+    fn log(&self, record: &log::Record<'_>) {
         if !self.enabled(record.metadata()) {
             return;
         }

src/main.rs

@@ -1,5 +1,20 @@
+#![deny(unsafe_code)]
+// Rustc lint groups
+#![warn(future_incompatible)]
+#![warn(rust_2018_idioms)]
+// Rustc lints
+#![warn(noop_method_call)]
+#![warn(single_use_lifetimes)]
+#![warn(trivial_numeric_casts)]
+#![warn(unused_crate_dependencies)]
+#![warn(unused_extern_crates)]
+#![warn(unused_import_braces)]
+#![warn(unused_lifetimes)]
+#![warn(unused_qualifications)]
+// Clippy lints
 #![warn(clippy::use_self)]
 
+// TODO Enable warn(unreachable_pub)?
 // TODO Clean up use and manipulation of toss Pos and Size
 
 mod euph;

src/ui.rs

@@ -58,7 +58,7 @@ impl Ui {
         terminal: &mut Terminal,
         vault: Vault,
         logger: Logger,
-        logger_rx: mpsc::UnboundedReceiver<()>,
+        logger_rx: UnboundedReceiver<()>,
     ) -> anyhow::Result<()> {
         let (event_tx, event_rx) = mpsc::unbounded_channel();
         let crossterm_lock = Arc::new(FairMutex::new(()));
@@ -107,8 +107,8 @@ impl Ui {
     }
 
     async fn update_on_log_event(
-        mut logger_rx: mpsc::UnboundedReceiver<()>,
+        mut logger_rx: UnboundedReceiver<()>,
-        event_tx: &mpsc::UnboundedSender<UiEvent>,
+        event_tx: &UnboundedSender<UiEvent>,
     ) {
         while let Some(()) = logger_rx.recv().await {
             if event_tx.send(UiEvent::Redraw).is_err() {

src/ui/chat/blocks.rs

@@ -66,7 +66,7 @@ impl<I> Blocks<I> {
         }
     }
 
-    pub fn iter(&self) -> vec_deque::Iter<Block<I>> {
+    pub fn iter(&self) -> vec_deque::Iter<'_, Block<I>> {
         self.blocks.iter()
     }
 

src/ui/widgets/float.rs

@@ -48,14 +48,14 @@ impl Widget for Float {
             let available = (size.width - inner_size.width) as f32;
             // Biased towards the left if horizontal lands exactly on the
             // boundary between two cells
-            inner_pos.x = (horizontal * available as f32).floor().min(available) as i32;
+            inner_pos.x = (horizontal * available).floor().min(available) as i32;
         }
 
         if let Some(vertical) = self.vertical {
             let available = (size.height - inner_size.height) as f32;
             // Biased towards the top if vertical lands exactly on the boundary
             // between two cells
-            inner_pos.y = (vertical * available as f32).floor().min(available) as i32;
+            inner_pos.y = (vertical * available).floor().min(available) as i32;
         }
 
         frame.push(inner_pos, inner_size);

src/vault/euph.rs

@@ -406,7 +406,7 @@ impl EuphRequest {
         Ok(())
     }
 
-    fn insert_msgs(tx: &Transaction, room: &str, msgs: Vec<Message>) -> rusqlite::Result<()> {
+    fn insert_msgs(tx: &Transaction<'_>, room: &str, msgs: Vec<Message>) -> rusqlite::Result<()> {
         let mut insert_msg = tx.prepare(
             "
             INSERT OR REPLACE INTO euph_msgs (
@@ -475,7 +475,7 @@ impl EuphRequest {
     }
 
     fn add_span(
-        tx: &Transaction,
+        tx: &Transaction<'_>,
         room: &str,
         start: Option<Snowflake>,
         end: Option<Snowflake>,

src/vault/migrate.rs

@@ -16,9 +16,9 @@ pub fn migrate(conn: &mut Connection) -> rusqlite::Result<()> {
     tx.commit()
 }
 
-const MIGRATIONS: [fn(&mut Transaction) -> rusqlite::Result<()>; 2] = [m1, m2];
+const MIGRATIONS: [fn(&mut Transaction<'_>) -> rusqlite::Result<()>; 2] = [m1, m2];
 
-fn m1(tx: &mut Transaction) -> rusqlite::Result<()> {
+fn m1(tx: &mut Transaction<'_>) -> rusqlite::Result<()> {
     tx.execute_batch(
         "
         CREATE TABLE euph_rooms (
@@ -76,7 +76,7 @@ fn m1(tx: &mut Transaction) -> rusqlite::Result<()> {
     )
 }
 
-fn m2(tx: &mut Transaction) -> rusqlite::Result<()> {
+fn m2(tx: &mut Transaction<'_>) -> rusqlite::Result<()> {
     tx.execute_batch(
         "
         CREATE TABLE euph_cookies (