Fix incorrect room name in url

I naïvely implemented Display for RoomIdentifier, which lead to me
passing room names like "&test@euphoria.leet.nu" to euphoxide instead of
"test". Of course, no room of that name exists, so every attempted
connection failed.

To figure this out, I manually relaxed the verbosity filters to let
through all euphoxide log messages and recompiled.

Only implementing Debug led to compile errors whereever I misused the
Disply instance, so at least the bug fix was nice and easy once I knew
what happened.
This commit is contained in:
Joscha 2024-01-01 01:49:11 +01:00
parent 78bbfac2f3
commit 60fdc40a21
3 changed files with 5 additions and 5 deletions

View file

@ -187,7 +187,7 @@ impl Room {
None => None, None => None,
}; };
debug!("{}: requesting logs", vault.room()); debug!("{:?}: requesting logs", vault.room());
// &rl2dev's message history is broken and requesting old messages past // &rl2dev's message history is broken and requesting old messages past
// a certain point results in errors. By reducing the amount of messages // a certain point results in errors. By reducing the amount of messages

View file

@ -101,8 +101,8 @@ impl EuphRoom {
let instance_config = self let instance_config = self
.server_config .server_config
.clone() .clone()
.room(self.vault().room().to_string()) .room(self.vault().room().name.clone())
.name(format!("{room}-{}", next_instance_id)) .name(format!("{room:?}-{}", next_instance_id))
.human(true) .human(true)
.username(self.room_config.username.clone()) .username(self.room_config.username.clone())
.force_username(self.room_config.force_username) .force_username(self.room_config.force_username)

View file

@ -46,13 +46,13 @@ impl FromSql for WTime {
} }
} }
#[derive(Debug, Clone, Hash, PartialEq, Eq, PartialOrd, Ord)] #[derive(Clone, Hash, PartialEq, Eq, PartialOrd, Ord)]
pub struct RoomIdentifier { pub struct RoomIdentifier {
pub domain: String, pub domain: String,
pub name: String, pub name: String,
} }
impl fmt::Display for RoomIdentifier { impl fmt::Debug for RoomIdentifier {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "&{}@{}", self.name, self.domain) write!(f, "&{}@{}", self.name, self.domain)
} }