Update toss and crossterm event polling

This commit is contained in:
Joscha 2022-06-08 19:00:27 +02:00
parent 00c905eff5
commit 84d554dee9
4 changed files with 52 additions and 20 deletions

7
Cargo.lock generated
View file

@ -191,6 +191,7 @@ dependencies = [
"clap", "clap",
"crossterm", "crossterm",
"futures", "futures",
"parking_lot",
"thiserror", "thiserror",
"tokio", "tokio",
"toss", "toss",
@ -579,9 +580,9 @@ checksum = "21326818e99cfe6ce1e524c2a805c189a99b5ae555a35d19f9a284b427d86afa"
[[package]] [[package]]
name = "parking_lot" name = "parking_lot"
version = "0.12.0" version = "0.12.1"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "87f5ec2493a61ac0506c0f4199f99070cbe83857b0337006a30f3e6719b8ef58" checksum = "3742b2c103b9f06bc9fff0a37ff4912935851bee6d36f3c02bcc755bcfec228f"
dependencies = [ dependencies = [
"lock_api", "lock_api",
"parking_lot_core", "parking_lot_core",
@ -1077,7 +1078,7 @@ dependencies = [
[[package]] [[package]]
name = "toss" name = "toss"
version = "0.1.0" version = "0.1.0"
source = "git+https://github.com/Garmelon/toss.git?rev=33264b4aec27066e6abb7cc7d15bd680b43fcd5a#33264b4aec27066e6abb7cc7d15bd680b43fcd5a" source = "git+https://github.com/Garmelon/toss.git?rev=333cf74fba56080043a13b9f55c0b62695e2fa4a#333cf74fba56080043a13b9f55c0b62695e2fa4a"
dependencies = [ dependencies = [
"crossterm", "crossterm",
"unicode-linebreak", "unicode-linebreak",

View file

@ -8,6 +8,7 @@ anyhow = "1.0.57"
clap = { version = "3.1.18", features = ["derive"] } clap = { version = "3.1.18", features = ["derive"] }
crossterm = { version = "0.23.2", features = ["event-stream"] } crossterm = { version = "0.23.2", features = ["event-stream"] }
futures = "0.3.21" futures = "0.3.21"
parking_lot = "0.12.1"
thiserror = "1.0.31" thiserror = "1.0.31"
tokio = { version = "1.18.2", features = ["full"] } tokio = { version = "1.18.2", features = ["full"] }
toss = { git = "https://github.com/Garmelon/toss.git", rev = "33264b4aec27066e6abb7cc7d15bd680b43fcd5a" } toss = { git = "https://github.com/Garmelon/toss.git", rev = "333cf74fba56080043a13b9f55c0b62695e2fa4a" }

View file

@ -8,6 +8,7 @@ use ui::Ui;
#[tokio::main] #[tokio::main]
async fn main() -> anyhow::Result<()> { async fn main() -> anyhow::Result<()> {
let mut terminal = Terminal::new()?; let mut terminal = Terminal::new()?;
terminal.set_measuring(true);
Ui::run(&mut terminal).await?; Ui::run(&mut terminal).await?;
Ok(()) Ok(())
} }

View file

@ -1,12 +1,16 @@
use std::collections::hash_map::Entry; use std::collections::hash_map::Entry;
use std::sync::{Arc, Weak};
use std::time::Duration;
use crossterm::event::{Event, EventStream, KeyCode, KeyEvent, MouseEvent}; use crossterm::event::{Event, EventStream, KeyCode, KeyEvent, MouseEvent};
use crossterm::style::ContentStyle; use crossterm::style::ContentStyle;
use futures::StreamExt; use futures::StreamExt;
use parking_lot::FairMutex;
use tokio::sync::mpsc::error::TryRecvError; use tokio::sync::mpsc::error::TryRecvError;
use tokio::sync::mpsc::{self, UnboundedReceiver, UnboundedSender}; use tokio::sync::mpsc::{self, UnboundedReceiver, UnboundedSender};
use tokio::task;
use toss::frame::{Frame, Pos}; use toss::frame::{Frame, Pos};
use toss::terminal::{Redraw, Terminal}; use toss::terminal::Terminal;
#[derive(Debug)] #[derive(Debug)]
pub enum UiEvent { pub enum UiEvent {
@ -24,26 +28,46 @@ pub struct Ui {
} }
impl Ui { impl Ui {
fn new(event_tx: UnboundedSender<UiEvent>) -> Self { const POLL_DURATION: Duration = Duration::from_millis(100);
Self { event_tx }
}
pub async fn run(terminal: &mut Terminal) -> anyhow::Result<()> { pub async fn run(terminal: &mut Terminal) -> anyhow::Result<()> {
let (event_tx, event_rx) = mpsc::unbounded_channel(); let (event_tx, event_rx) = mpsc::unbounded_channel();
let mut ui = Self::new(event_tx.clone()); let crossterm_lock = Arc::new(FairMutex::new(()));
// Prepare and start crossterm event polling task
let weak_crossterm_lock = Arc::downgrade(&crossterm_lock);
let event_tx_clone = event_tx.clone();
let crossterm_event_task = task::spawn_blocking(|| {
Self::poll_crossterm_events(event_tx_clone, weak_crossterm_lock)
});
// Run main UI.
//
// If the run_main method exits at any point or if this `run` method is
// not awaited any more, the crossterm_lock Arc should be deallocated,
// meaning the crossterm_event_task will also stop after at most
// `Self::POLL_DURATION`.
//
// On the other hand, if the crossterm_event_task stops for any reason,
// the rest of the UI is also shut down and the client stops.
let mut ui = Self { event_tx };
let result = tokio::select! { let result = tokio::select! {
e = ui.run_main(terminal, event_tx.clone(), event_rx) => e, e = ui.run_main(terminal, event_rx, crossterm_lock) => e,
e = Self::shovel_crossterm_events(event_tx) => e, Ok(e) = crossterm_event_task => e,
}; };
result result
} }
async fn shovel_crossterm_events(tx: UnboundedSender<UiEvent>) -> anyhow::Result<()> { fn poll_crossterm_events(
// Implemented manually because UnboundedSender doesn't implement the Sink trait tx: UnboundedSender<UiEvent>,
let mut stream = EventStream::new(); lock: Weak<FairMutex<()>>,
while let Some(event) = stream.next().await { ) -> anyhow::Result<()> {
tx.send(UiEvent::Term(event?))?; while let Some(lock) = lock.upgrade() {
let _guard = lock.lock();
if crossterm::event::poll(Self::POLL_DURATION)? {
let event = crossterm::event::read()?;
tx.send(UiEvent::Term(event))?;
}
} }
Ok(()) Ok(())
} }
@ -51,18 +75,23 @@ impl Ui {
async fn run_main( async fn run_main(
&mut self, &mut self,
terminal: &mut Terminal, terminal: &mut Terminal,
event_tx: UnboundedSender<UiEvent>,
mut event_rx: UnboundedReceiver<UiEvent>, mut event_rx: UnboundedReceiver<UiEvent>,
crossterm_lock: Arc<FairMutex<()>>,
) -> anyhow::Result<()> { ) -> anyhow::Result<()> {
loop { loop {
// 1. Render current state // 1. Render current state
terminal.autoresize()?; terminal.autoresize()?;
self.render(terminal.frame()).await?; self.render(terminal.frame()).await?;
if terminal.present()? == Redraw::Required { terminal.present()?;
event_tx.send(UiEvent::Redraw);
// 2. Measure widths if required
if terminal.measuring_required() {
let _guard = crossterm_lock.lock();
terminal.measure_widths()?;
self.event_tx.send(UiEvent::Redraw)?;
} }
// 2. Handle events (in batches) // 3. Handle events (in batches)
let mut event = match event_rx.recv().await { let mut event = match event_rx.recv().await {
Some(event) => event, Some(event) => event,
None => return Ok(()), None => return Ok(()),